-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for indexing serialized arrays #346
base: master
Are you sure you want to change the base?
Support for indexing serialized arrays #346
Conversation
Hi @mweimerskirch, Thanks for the pull request. Could you open an issue first so we can discuss before you spend too much time on the implementation? Including additional details on your use case, etc. would be great. |
@danielbachhuber I'm used to discussing these details right in the pull request, as comments can be added to the commit and I can later on easily "rebase" the code and replace the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the failed build, and add a test case for this scenario?
Two notes on this: The schema won't like this-- I would also recommend handling integer/float/decimal values, so you may want to move the checker up a bit. And finally, (I'm handling these manually myself via the EDIT: |
@cjcodes Did you come up with a good solution for this that you'd want to submit a pull request for? |
If the value is an array, recursively "implode" all values with a linebreak character. Many plugins store data (e. g. repeatable text boxes) as serialized arrays in the post_meta table. This changes makes it easier to index them properly without indexing control characters or array index names.
728ccc2
to
671e1a3
Compare
If the value is an array, recursively "implode" all values with a linebreak character.
Many plugins store data (e. g. repeatable text boxes) as serialized arrays in the post_meta table. This change makes it easier to index them properly without indexing control characters or array index names.